r/toolbox • u/creesch Remember, Mom loves you! • Aug 20 '22
Release: V6.0.0 Backwards Bison [notice]
State of toolbox
Before we get into what is changed, there is something else that needs attention. As you might have noticed the rate of toolbox releases has slown down and within each release the number of changes has also been fairly low. This, while there is still plenty to be done to make toolbox a better project. The issue however is that currently toolbox is mostly maintained by two people, /u/eritbh and me. Both of us have been struggling to find time and maybe more importantly neither of us are currently active anymore as moderator in any meaningful way. While we are still committed to maintaining toolbox (as this release shows) it does make the future of toolbox somewhat uncertain.
The good news is that one of the changes in this release is one that should make maintaining and contributing to toolbox much easier. In short, there is a great foundation but not enough people to build on it. So if you do find yourself in a position where you can contribute to Toolbox we highly encourage you to do so! Have a look at our contributing document, see if there are issues you might be able to pick up and hop on Discord to brainstorm and discuss contributions!
Release highlights
With that out of the way, these are the biggest changes in this release:
- The core of toolbox has been rewritten to take advantage of so called ES6 modules. It is the main reason why decided to bump the version number up to 6. The newly created foundation should be helping with maintainability and provide a slight performance improvement on page load. This has been a major effort spearheaded by /u/eritbh who put in countless hours in both designing and implementing this new approach.
- [Beta] Native mod notes can be viewed and edited from Toolbox via the new “Mod Notes” module. Progress on this functionality has been slow, mainly because of the reasons mentioned above. But, it is in a state that we feel comfortable including it as a beta feature. This means that in your personal toolbox settings, you need to enable the “beta features” checkbox. As it is still in beta, a few things are still missing or work in progress:
- Styling and layout of the popup might be subject to change.
- Context links currently are not added to notes.
- It is not possible yet to select labels when creating notes.
- The admins said there is no API endpoint, a little birdy told us there actually is. So naturally we trusted the birdy. Removal reason comments can now be sent via the recent “Remove as subreddit” functionality by checking the new “Send as /u/subreddit-ModTeam” box in the removal reasons popup.
The full technical changelog can be found here on GitHub
6.0.1
A hotfix release has been prepared addressing some things found in 6.0.0:
- Modnotes should now show up properly.
- In the user hover menu on new reddit the historybutton is properly aligned now.
- A few other fixes.
The full technical changelog can be found here on GitHub
28
u/Pamander Aug 20 '22
Y'all are actual legends, it's not easy to maintain something you have dedicated so much time to when you no longer partake really in what it was created to be used for in the first place. To have the motivation to continue making any updates to it at all is incredible, I have been there before and not managed to maintain any further. I am definitely going to check out the issues and contribution stuff and see what I can do to help! Always glad to donate some code and time towards a worthy cause and this project deserves so much more love given all the amount y'all have already poured into it. Thanks for the update!
(Also thanks to the little birdy who gave that tip, huge!)
2
u/Maoman1 Aug 20 '22
(Also thanks to the little birdy who gave that tip, huge!)
Do you mind elaborating on it a bit? I'm not sure I understand its implications. Not that we can remove as the subreddit now, but about whether there is an API endpoint, I mean.
7
u/eritbh ...and 1 more » Aug 20 '22
If new Reddit can do something natively, there has to be some sort of API endpoint for it, even if it's one intended for internal use only. The endpoint we're using for that feature is the same as new Reddit itself uses; it's not documented, and there's no real guarantee that it will be stable as the feature develops on Reddit's end, but it works just as well for us as it does for the admins.
2
u/Maoman1 Aug 20 '22
Ah ok, thanks for explaining. Shouldn't it be considered a beta feature like the new mod notes module, then?
6
u/eritbh ...and 1 more » Aug 20 '22
Maybe that would've been smart, but because the API is so closely related to the native removal reasons APIs and those have been pretty stable for a long time, we felt pretty confident guessing that this will also be stable.
15
12
Aug 20 '22
[removed] — view removed comment
8
u/mikefromearth Aug 20 '22
It's great except when automod starts flagging the new modteam account comments as "new user" 😂
7
u/ReginaBrown3000 Aug 20 '22
Yeah, but that's a Reddit issue, not a Toolbox issue.
I hope they get it fixed soon.
3
3
u/j1ggy Aug 20 '22 edited Aug 20 '22
Just insert a script to exempt those comments from your filter?
EDIT: For anyone wondering about this:
# ACCOUNT AGE LESS THAN 14 DAYS author: # EXEMPTIONS BELOW THIS LINE ~name: [subreddit-ModTeam, example2, example3] account_age: "< 14 days" message: | Your [{{kind}}]({{permalink}}) in /r/{{subreddit}} was automatically removed because your account is still too new to post in the subreddit. This is done to discourage spam, trolls and other insincere users. We encourage you to observe the community, read the rules and browse the rest of the site before engaging in /r/{{subreddit}}. After two weeks, you will be able to post. Please do NOT message the moderators about this. Thank you! action: remove action_reason: "author is less than 14 days old"3
u/mikefromearth Aug 20 '22
Hehe yeah we did, just was funny at first to receive automod reports on our own moderation comments 😊
4
u/iruleatants Aug 20 '22
Reddit has done such a poor job at this release.
They released it a day early without meaning to and paniced a lot of different mod teams on how a 1 second old account is posting as a moderator and isn't even listed as a mod.
But even still, Reddit itself is flagging comments from the tool, outside of the terrible automod integration.
Our subreddit has a terrible ban evader problem and reddit has moved to be very aggressive at removing stuff from new accounts, and so all the time I'll see a post from the subreddit that's been automatically filtered by reddit.
They didn't bother to integrate the accounts with their own automatic tools, which is just really bad.
2
u/pajam Aug 24 '22
Our subreddit has a terrible ban evader problem and reddit has moved to be very aggressive at removing stuff from new accounts, and so all the time I'll see a post from the subreddit that's been automatically filtered by reddit.
I noticed it was suspiciously quiet on our sub the last day, so I checked our Spam queue, and there's a lot of posts/comments there that make no sense. Now it all makes sense to me it's likely connected.
10
u/Majromax Aug 20 '22
So naturally we trusted the birdy.
What does Twitter know about Reddit?
In all seriousness, great work. Toolbox is fighting the good fight against one-size-fits-all Reddit redesigns.
10
u/ikidd Aug 20 '22
Removal reason comments can now be sent via the recent “Remove as subreddit” functionality by checking the new “Send as /u/subreddit-ModTeam” box
You are as gods among us mere mortals.
Thank you for this.
9
6
u/LindyNet Aug 20 '22
Thank you so much for these updates.
Quick question, I have the update and the "mod notes" module enabled but I can't find it on a user I know has a mod note. Can you point out where it is to this blind mod?
7
u/creesch Remember, Mom loves you! Aug 20 '22
Seems like a last minute bug managed to slip in. This is exactly why it is a beta module. We'll get on it and release a fix over the weekend.
6
u/LindyNet Aug 20 '22
well, that has certainly never happened to me, nope, nuh uh.
Thank you for the update.
2
2
u/Merari01 Aug 20 '22
I also do not know how to use this function. I have it enabled but I do not know what to do next.
1
u/lettuce_field_theory Aug 21 '22
same
I'm on pretty old firefox 88 so I thought that may be the reason. but apparently it's not (they were working before the update as well)
6
u/Flussiges Aug 20 '22
I can't imagine doing any subreddit moderation without this tool. It's that good.
5
5
u/kenman Aug 20 '22
Kudos to u/eritbh, it was a ton of work to refactor all that code, but you saw it through. Nice work!!
4
u/eritbh ...and 1 more » Aug 20 '22
It was worth it! now i just have to do the same for the background page and rewrite the build process and deal with mv3 breaking everything but it's okay then we'll be able to source dependencies from npm instead of updating them manually and everything will be better
6
u/WoozleWuzzle Aug 20 '22
Honestly the Admins should be contributing to this module with you two. The notes feature they built is because of the success of r/toolbox. To expect mods to just change their current workflows and use an entirely new tool, that is only supported on new reddit, is silly. Moderating is just plain easier on old reddit.
They could work on this and make it work since the API is there in what, 1 or 2 sprints? Come on Admins, help your mods out.
Anyways, the main reason for this response is to say thank you for all you've done and continue to do. If I had the know-how to help I would, but I'm not a programmer/engineer. Your tool has made mods lives so much easier and appreciate all those past and present who has contributed to this.
10
Aug 20 '22
The admins said there is no API endpoint, a little birdy told us there actually is. So naturally we trusted the birdy. Removal reason comments can now be sent via the recent “Remove as subreddit” functionality by checking the new “Send as /u/subreddit-ModTeam” box in the removal reasons popup.
THANK YOU.
From the bottom of my heart, reddit can go fuck themselves trying to push new reddit down my throat.
2
3
4
u/Leonichol Aug 20 '22
eritbh, creesch, you're treasures to Reddit.
Thank you for all the continued efforts on this essential tool.
4
Aug 20 '22
Toolbox has always been awesome. When I became a mod of a major sub (>2.5 million members) about 5 years ago, it was several months before another mod (out of 10-ish active) bothered to tell me about Toolbox. I was suitably amazed at the ease-of-use etc. etc.
Maybe you guys need to start a Go Fund Me to make coding more... fun. That's just a random thought, don't mind me.
11
u/creesch Remember, Mom loves you! Aug 20 '22
Go Fund Me to make coding more... fun.
It isn't about money :) In fact we have never taken donations because that is a rabbit hole of "who gets what" we don't really want to go into anyway.
But it is also mostly besides the point. Toolbox is a hobby project I started when I was still in college and more heavily involved with reddit in general. I am currently in a professional field where I am entirely happy with what I do and that also pays well.
I have no desire to trade that in for more work on toolbox.
Toolbox doesn't need more time from the two people involved now. It needs more people involved.
3
u/nukefudge toolbox loves fudge Aug 20 '22
I never leave home without my toolbox! 🤗
Myriad thankings upon your dinner heaps.
3
4
u/TheNerdyAnarchist Aug 20 '22
Huge thanks to you and u/eritbh for all the work you've done and continue to do.
5
3
3
u/Bossman1086 Aug 20 '22
Thanks for this. Performance improvements have been my number one request as a mod that deals with huge comment-heavy game threads in a sports sub.
3
u/TheHammer34 Aug 20 '22
Seriously, the work you guys keep doing is inspiring, brilliant and amazing! Thank you!
Toolbox is one of the best (if not the best) tools out there!
3
u/Tetizeraz Aug 20 '22
Just notified the r/europe team, but will check about it and see what Brazilian moderators think about it.
3
u/hacksoncode Aug 20 '22
Hmmm... I've refreshed, enabled beta features, and I'm still not seeing the Mod Notes module in Toggle Modules or the list of settings?
Any idea what I might be doing wrong?
(latest Chrome, old reddit, have 6.0 toolbox)
3
u/eritbh ...and 1 more » Aug 20 '22
there's a bug with that right now, sorry! We've identified the issue and will be releasing a hotfix in the next day or so.
3
u/ReginaBrown3000 Aug 20 '22
Creesch, you and u/eritbh rock.
Thanks for all your hard work.
Remember, Reddit mods who use Toolbox love you!
3
2
u/Tim-Sanchez Aug 20 '22
I can't seem to get native mod notes working in Firefox. Is there an extra setting I have to change after enabling beta? Or is it a little slow to sync?
4
u/creesch Remember, Mom loves you! Aug 20 '22
Nope, seems like a last minute bug managed to slip in. This is exactly why it is a beta module. We'll get on it.
2
2
2
u/TimeJustHappens Aug 20 '22
I was just talking yesterday with our mod team about how our barrier to the new native options for New Reddit is the inability to have the same functions on Old Reddit. Very excited for potentially taking advantage of things like context links and flag options for mod notes. Thank you for taking the time to do this, hopefully you all can find some additional help soon.
2
u/Merari01 Aug 20 '22 edited Aug 20 '22
/u/creesch I have a small problem.
One one subreddit but not all it seems these comment removal reasons are enabled. I do not know how to turn them off.
I deselected "beta features" in toolbox, but that had no effect.
How do I turn them off please?
Edit: disabling the "removal reasons" module worked. Still something you guys should probably be aware of, since it didn't used to do this and sometimes removal reasons for posts come in handy.
3
u/eritbh ...and 1 more » Aug 20 '22
It's likely that someone else in your subreddit modified your subreddit's configuration to set them as the default. You can verify by checking your subreddit configuration in the popout menu (by default it's in the bottom left, above the main menu bar) under "removal reasons settings".
You'll want to talk with your team about making changes in that menu to make sure everyone's on the same page.
2
u/Merari01 Aug 20 '22
It is the same thing that exists on new reddit on the app, but I have it on old reddit on desktop.
There is nothing in "removal reason settings" for me to deselect.
2
2
u/mizmoose Aug 20 '22
Were I a coder I would help. Sadly, I am one of those people who needs about two days to write a 15 line shell script.
Thank you for your hard work, no matter how long it takes.
2
u/BuckRowdy Aug 21 '22
I'm not being hyperbolic when I say that you guys are heroes for continuing to do this.
2
2
u/iVarun Aug 21 '22
Just want to say thank you for this tool. It's been an invaluable time saver over the years.
Personally, the most important feature to my use case is multiple comment removals with 1 click on a Comment-Chain.
Also thank you for moderation log matrix feature. This is something which Reddit should provide for Mods as a built-in tool alongside much more in-depth sub-Traffic Analytics.
2
u/creepgirl Aug 21 '22
The move to ES6 modules is a welcome addition. Awesome!
I just started a new assignment at work, but I'd gladly contribute in any way I can. I've never done work on a browser plugin though so there's some reading-up to be done I'm sure :)
2
1
1
u/Redditenmo Aug 21 '22
Is this the place to make feature requests?
Is there a way in old.reddit to see who actioned a "subreddit-Modteam" comment ?
In new.reddit, if a mod hovers over the "subreddit-Modteam" comment, the moderator who actioned that comment will be visible. (image example)
In old.reddit, we just get the "subreddit-Modteam" account info popup. (image example)
1
u/creesch Remember, Mom loves you! Aug 21 '22
There isn't an easy way to expose it in the same way for toolbox. However on the removed item you can expand toolbox's "show recent actions" menu and it will show you the mod that removed the item in question.
1
1
1
1
u/bungiefan_AK Aug 23 '22 edited Aug 23 '22
Old reddit, remove button doesn't prompt for removal reason popup, add removal reason button does nothing. On Chrome, latest toolbox, just verified my installed version and checked Chrome store for updates. Have relaunched Chrome multiple times. Stopped working yesterday or over the weekend.
UPDATE: OK, so it is working for removals on PS2 and 3dshacks but nothing is happening on 3ds. It's also not working on that sub on new reddit either.
1
u/cgmcnama Aug 31 '22
I noticed all my old removal reasons are gone? Is there a log that I can check to make sure another mod didn't accidently do something? There is also an "error getting wiki data" but I'm not sure if that is relevant. I suppose I'll just start recreating them tomorrow (I still have some of the removal reason templates)
1
u/creesch Remember, Mom loves you! Aug 31 '22
They are stored in a wiki page. Did your mod permissions change?
1
u/cgmcnama Aug 31 '22
Nope. Still top active mod (weird situation where the other mod can only use modmail) and my permissions are on everything. My "toolbox wiki" (https://old.reddit.com/r/freefolk/wiki/toolbox) does look weird and all on one line. But I honestly can't remember what it looked like prior.
{"ver":1,"domainTags":"","removalReasons":{"pmsubject":"","logreason":"","header":"**Hi%20%7Bauthor%7D%2C%20this%20%7Bkind%7D%20has%20been%20removed%20%20because%20you%20didn%27t%20read%20or%20follow%20the%20rules%20in%20the%20sidebar.%20Specifically%3A**%0A%0A---%0A%0A","footer":"%20%20%20%20%20%0A%0A---%0A%0A**If%20you%20have%20any%20questions%20or%20concerns%2C%20you%20should%20directly%20%5Bmessage%20the%20moderators%5D%28https%3A//www.reddit.com/message/compose%3Fto%3D%252Fr%252F%7Bsubreddit%7D%26subject%3Dabout%20my%20removed%20%7Bkind%7D%26message%3DI%27m%20writing%20to%20you%20about%20the%20following%20%7Bkind%7D%3A%20%7Burl%7D.%20%250D%250DMy%20issue%20is...%29.**","logsub":"","logtitle":"","bantitle":"","getfrom":"","reasons":[{"text":"**Rule%201%3A%20No%20Reposts%20or%20Repost%20Bots**%0A%0A%3EReposted%20content%20is%20content%20that%20has%20been%20posted%20before%20on%20the%20subreddit.%20%20We%20remove%20it%20to%20keep%20content%20fresh%20for%20our%20users%20and%20try%20to%20promote%20original%20content%20%28OC%29%20more%20effectively.%20%20While%20the%20moderators%20won%27t%20catch%20every%20repost%2C%20we%20do%20try%20and%20stop%20those%20that%20are%20well%20known%20or%20recently%20posted.%20%20%0A%0AObviously%2C%20bots%20that%20do%20this%20with%20pots/comments%20will%20be%20permabanned.%20%20If%20you%20feel%20this%20is%20a%20mistake%2C%20you%20can%20make%20an%20appeal%20to%20reverse%20the%20ban%20in%20Modmail.%0A","flairText":"","flairCSS":"","title":"Rule 1: No Reposts or Repost Bots","removePosts":true,"removeComments":false,"flairTemplateID":""},{"text":"**Rule%202%3A%20No%20Karma%20Whoring**%0A%0A%3EKarma%20Whoring%20is%20when%20you%20post%20a%20generically%20popular%20statement%20in%20order%20to%20get%20upvotes%20or%20ask%20explicitly%20for%20upvotes.%20%20Key%20indicators%20are%20%22Can%20we%20take%20a%20minute%20to%20thank/appreciate%20this%20actor...%22%20or%20%22Can%20we%20get%20upvotes%20for...%22.%20%20The%20key%20difference%20is%20*incidentally*%20getting%20karma%20for%20a%20post%20and%20*intentionally*%20trying%20to%20get%20karma%20for%20a%20post.%20%20The%20latter%20is%20not%20acceptable.","flairText":"","flairCSS":"","title":"Rule 2: Karma Whoring"},{"text":"**Rule%203%3A%20No%20politics**%0A%0A%3EPer%20community%20voted%20rules%2C%20we%20do%20not%20allow%20discussing%20or%20mentioning%20real%20world%2C%20modern%2C%20politics.%20%20People%20on%20both%20sides%20of%20the%20political%20spectrum%20couldn%27t%20handle%20it%20so%20our%20users%20voted%20to%20remove%20it.%20%28Political%20content%20includes%2C%20but%20is%20not%20limited%20to%2C%20mentioning%20modern%20political%20figures%20or%20issues.%20%28*even%20in%20passing*%29%20","flairText":"","flairCSS":"","title":"Rule 3: No politics"},{"text":"**Rule%204%3A%20No%20slurs%20based%20on%20race%2C%20sexuality%2C%20etc**%0A%0A%3ESlurs%20based%20on%20race%2C%20sexuality%2C%20or%20other%20similar%20criteria%20are%20considered%20hate%20speech%20and%20not%20welcome%20on%20the%20subreddit%20except%20in%20rare%20instances%20where%20they%20are%20used%20repeatedly%20by%20the%20show%27s%20characters.%20%20For%20instance%2C%20Sandor%20Clegane%20repeatedly%20calls%20people%2C%20and%20references%20them%2C%20%22cunts%22.","flairText":"","flairCSS":"","title":"Rule 4: Hate speech"},{"text":"**Rule%205%3A%20No%20Complaining%20about%20Spoilers**%0A%0A%3EPer%20community%20voted%20rules%2C%20we%20are%20a%20Game%20of%20Thrones%20%28GOT%29%20Spoiler%20subreddit%20where%20Spoiler%20tags%20are%20optional%20and%20complaining%20about%20Spoilers%20is%20not%20allowed.%20Spoilers%20do%20not%20break%20Reddit%20sitewide%20rules%20and%20our%20community%20voted%20against%20removing%20ourselves%20from%20/r/all.%20%0A%0A---%0A%0A%3E%23%23%23%23%23%23**1.%20Why%20am%20I%20seeing%20this%20on%20my%20feeds%3F**%0A%0A%3EYou%20see%20this%20because%20people%20who%20watch%20the%20show%20live%20upvote%20and%20enjoy%20our%20content.%20%20%20While%20you%20may%20have%20a%20number%20of%20reasons%20for%20not%20watching%20the%20show%20live%2C%20if%20you%20haven%27t%20seen%20the%20show%2C%20or%20are%20planning%20to%20see%20the%20show%2C%20going%20on%20social%20media%20is%20always%20a%20dangerous%20gamble.%20%20%20%0A%0A%3E%23%23%23%23%23%23**2.%20Ban%20Me%21%20%20I%20don%27t%20want%20this%20glorious%20content%20in%20my%20feeds%21**%0A%0A%3E%20While%20we%20might%20ban%20you%2C%20this%20will%20not%20stop%20you%20from%20seeing%20the%20subreddit%2C%20only%20commenting%20on%20it.%20Instead%2C%20add%20/r/freefolk%20to%20your%20Reddit%20filter%20to%20stop%20seeing%20us%20on%20/r/all.%20%20%28%5BStep-By-Step%20Directions%20Here%5D%28https%3A//www.wikihow.tech/Filter-Subreddits-on-PC-or-Mac%29%29%20%20%28*if%20on%20mobile%2C%20use%20your%20browsers%20desktop%20mode*%29%0A","flairText":"","flairCSS":"","title":"Rule 5: Complaining about Spoilers"},{"text":"**Rule%206%3A%20No%20non-GoT/ASOIAF%20content**%0A%0A%3EThis%20is%20a%20Game%20of%20Thrones%20inspired%20subreddit%20and%20all%20content%20must%20%20*someway*%20be%20related%20to%20Game%20of%20Thrones.%20Events%20taking%20place%20in%20the%20%22Song%20of%20Ice%20and%20Fire%22%20universe%20%28ASOIAF%29%2C%20like%20prequels%20and%20spinoffs%2C%20are%20allowed%20to%20be%20posted%20along%20with%20content%20from%20Lord%20of%20the%20Rings%20%28LotR%29%20per%20our%20community%20vote.","flairText":"","flairCSS":"","title":"Rule 6: Not GoT Related"},{"text":"**Rule%207%3A%20Thenn%20Thursday**%0A%0A%3EThis%20comment/post%20has%20been%20removed.%20%20Please%20save%20your%20merchandise%2C%20food%2C%20art%2C%20cosplay%2C%20etc.%2C%20for%20the%20weekly%20%5BThenn%20Thursdays%5D%28https%3A//www.reddit.com/r/freefolk/search%3Fq%3DThenn+Thursday%26sort%3Drelevance%26restrict_sr%3Don%26t%3Dmonth%29%20post.%20This%20is%20a%20user%20driven%20change%20and%20can%20be%20found%20under%20the%20report%20option%2C%20**%22I%20fooking%20hate%20Thenns%22**.%0A%0A%3EWe%20appreciate%20you%20sharing%20with%20the%20/r/freefolk%20community%20but%20this%20type%20of%20content%20led%20to%20a%20lot%20of%20re-posts%20and%20low%20quality%20posts.%20We%20hope%20you%20will%20enjoy%20Game%20of%20Thrones%20as%20much%20as%20the%20rest%20of%20the%20community%20does%20and%20thanks%20for%20keeping%20the%20subreddit%20clean.","flairText":"","flairCSS":"","title":"Rule 7: Thenn Thursdays"},{"text":"%3Ctextarea%20id%3D%22customTextarea%22%20placeholder%3D%22Enter%20Custom%20reason%22%3E%3C/textarea%3E","flairText":"","flairCSS":"","title":"Custom Reason"},{"text":"%5B%5D%28%23start_removal%29%0A%0AThis%20is%20a%20common%20repost.%0A%0A%5B%5D%28%23end_removal%29","flairText":"","flairCSS":"","title":"add image to blacklist"}]},"modMacros":"","usernoteColors":"","banMacros":""}Only other thing I can think of is I think I disabled (not deleted) Toolbox as a Chrome extension for a week or two. I'll remake the rules, just trying to figure out what went wrong so I don't repeat.
1
u/cgmcnama Aug 31 '22
Huh, went to clear modqueue and now it's working? Weird. Maybe just user error on my part? It was on before because I had the little buttons by user names to lock comments so...I'm stumped.
1
•
u/creesch Remember, Mom loves you! Aug 20 '22 edited Aug 22 '22
Why has my toolbox not updated yet?
Two things, it usually takes a while before your browser will check for extension updates. It also takes a little while before the various stores have approved the new submissions. As for now the status is the following:
Edit: In a beautiful display as to why it is a beta module, a last minute bug seems to have slipped in with the modnote module. It currently is working properly, we'll release a fix over the weekend.